chore: pin all workflow actions to full commit SHAs#715
Merged
aaronlippold merged 2 commits intomasterfrom Apr 8, 2026
Merged
Conversation
Closes #710 - Move docker-release job to dedicated release.yml, triggered only on release published events without re-running the test suite - Remove release trigger from ci.yml (push/PR only) - Pin all GitHub Actions to full commit SHAs for supply chain safety - Fix SBOM tag mismatch (v2.3.4 vs 2.3.4) by using metadata output Signed-off-by: Will <will@dower.dev>
There was a problem hiding this comment.
Pull request overview
Splits release publishing from the main CI workflow by moving Docker image publishing into a dedicated workflow triggered on GitHub Release publish events.
Changes:
- Added a new
release.ymlworkflow that builds/pushes the multi-arch Docker image onrelease: publishedand submits an SBOM/dependency snapshot. - Updated
ci.ymlto remove thereleasetrigger and delete the in-workflowdocker-releasejob (CI now runs on push/PR only). - Pinned the actions used by CI and the new release workflow to full commit SHAs, and updated SBOM tagging to use Docker metadata output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/release.yml | New release-only workflow to build/push Docker images and submit SBOM/dependency snapshot. |
| .github/workflows/ci.yml | CI now runs only on push/PR; removes release job/trigger and pins actions to SHAs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aaronlippold
previously approved these changes
Apr 8, 2026
- Pin docs.yml and dependabot.yml actions to full commit SHAs - Update release_infrastructure_spec to check release.yml instead of ci.yml for the docker-release trigger Signed-off-by: Will <will@dower.dev>
|
aaronlippold
approved these changes
Apr 8, 2026
Copilot
AI
changed the title
feat: split CI and release into separate workflows
chore: pin all workflow actions to full commit SHAs
Apr 8, 2026
wdower
added a commit
that referenced
this pull request
Apr 12, 2026
Release metadata for v2.3.5 covering PRs #715 (CI/release workflow split) and #716 (server-side user search, information disclosure fix, editor refresh shape drift fix). - VERSION: v2.3.4 → v2.3.5 - package.json: 2.3.4 → 2.3.5 - CHANGELOG.md: new v2.3.5 section - docs/release-notes/index.md: promote v2.3.4, add v2.3.5 - docs/release-notes/v2.3.5.md: new release notes Signed-off-by: Will Dower <will@dower.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial CI/release split only pinned actions in
ci.ymlandrelease.yml, leavingdocs.ymlanddependabot.ymlstill referencing mutable version tags — inconsistent with the supply chain safety goal.Changes
docs.yml— pinactions/checkout,actions/setup-node,actions/configure-pages,actions/upload-pages-artifact,actions/deploy-pagesto full commit SHAsdependabot.yml— pinhmarr/auto-approve-actionto full commit SHAAll pinned references retain the human-readable version tag as an inline comment (e.g.,
# v4).